Omnia beegfs issue#621 #626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @kbuggenhout! I know you're still working on this, but you should go back and sign each of your commits using the
Going forward, please be sure to add Thanks so much for working on this! |
Author
|
Hi Luke,
thats why I did a draft pull request :)
wasnt sure the -s option took. will do the rebase and re-issue the signoff
a bit rusty on the github workings :)
will get up to speed soon enough.
basic are in, will need to start functional testing, yamllint only complains on line lengths and spaces, using it out of the box, which is quite restrictive.
havent done the config file for yamllint yet... :)
k rgrds, Kris
Van: "Lucas A. Wilson" ***@***.***>
Aan: "dellhpc/omnia" ***@***.***>
Cc: "buggenhout" ***@***.***>, "Mention" ***@***.***>
Verzonden: Maandag 25 oktober 2021 16:28:29
Onderwerp: Re: [dellhpc/omnia] Omnia beegfs issue#621 (PR #626)
Hey [ https://github.com/kbuggenhout | @kbuggenhout ] ! I know you're still working on this, but you should go back and sign each of your commits using the --signoff option to git commit :
You have 2 commits incorrectly signed off. To fix, first ensure you have a local copy of your branch by checking out the pull request locally via command line. Next, head to your local branch and run:
git rebase HEAD~2 --signoff
Now your commits will have your sign off. Next run
git push --force-with-lease origin omnia_beegfs_issue#621
Going forward, please be sure to add --signoff to all of your commits (every time you use git commit )!
Thanks so much for working on this!
—
You are receiving this because you were mentioned.
Reply to this email directly, [ #626 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AHIPME7QQC45ZSMXQMERUY3UIVSQ3ANCNFSM5GSTG3DQ | unsubscribe ] .
Triage notifications on the go with GitHub Mobile for [ https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 | iOS ] or [ https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub | Android ] .
|
added 2 commits
October 25, 2021 16:41
Signed-off-by: kbuggenhout <[email protected]>
Signed-off-by: kbuggenhout <[email protected]>
kbuggenhout
force-pushed
the
omnia_beegfs_issue#621
branch
from
3f7ebd6 to
f1e1a51
Compare
Author
|
should now be rebased with --signoff
still doing some work on it, going to to a testrun on a standalone ansible setup in a vm. see if it actually does what I think it should do :)
have to work on the interactivity to select the devices to use for the storage, currently with manual array configuration, am in conversation with the team that has been doing the ME4 code, to add support ffor BeeGFS configs on ME4024 and ME4084.
to be continued
k rgrds, Kris
Van: "Lucas A. Wilson" ***@***.***>
Aan: "dellhpc/omnia" ***@***.***>
Cc: "buggenhout" ***@***.***>, "Mention" ***@***.***>
Verzonden: Maandag 25 oktober 2021 16:28:29
Onderwerp: Re: [dellhpc/omnia] Omnia beegfs issue#621 (PR #626)
Hey [ https://github.com/kbuggenhout | @kbuggenhout ] ! I know you're still working on this, but you should go back and sign each of your commits using the --signoff option to git commit :
You have 2 commits incorrectly signed off. To fix, first ensure you have a local copy of your branch by checking out the pull request locally via command line. Next, head to your local branch and run:
git rebase HEAD~2 --signoff
Now your commits will have your sign off. Next run
git push --force-with-lease origin omnia_beegfs_issue#621
Going forward, please be sure to add --signoff to all of your commits (every time you use git commit )!
Thanks so much for working on this!
—
You are receiving this because you were mentioned.
Reply to this email directly, [ #626 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AHIPME7QQC45ZSMXQMERUY3UIVSQ3ANCNFSM5GSTG3DQ | unsubscribe ] .
Triage notifications on the go with GitHub Mobile for [ https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 | iOS ] or [ https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub | Android ] .
|
Collaborator
|
Looks good now, @kbuggenhout! Thanks for digging into this! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Collaborator
|
Keeping this draft PR alive. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved by this Pull Request
Please be sure to associate your pull request with one or more open issues. Use the word Fixes as well as a hashtag (#) prior to the issue number in order to automatically resolve associated issues (e.g., Fixes #100).
Fixes #621
Description of the Solution
adding base ansible role with tasks to install manager, metadata OSS servere and beegfs client stack
Suggested Reviewers
If you wish to suggest specific reviewers for this solution, please include them in this section. Be sure to include the @ before the GitHub username.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
660 York Street, Suite 102,
San Francisco, CA 94110 USA
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.